jorisvandenbossche commented on a change in pull request #7395:
URL: https://github.com/apache/arrow/pull/7395#discussion_r443535516
##########
File path: python/pyarrow/tests/test_dataset.py
##########
@@ -1117,6 +1115,15 @@ def test_open_dataset_from_uri_s3(s3_connection,
s3_server):
with fs.open_output_stream("mybucket/data.parquet") as out:
pq.write_table(table, out)
+ return table, path, fs, uri, host, port, access_key, secret_key
Review comment:
Since I only unpack it below (like `table, path, _, _, host, port,
access_key, secret_key = s3_example_simple`), I am not sure using a namedtuple
will help much (the unpacking won't check names or so)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
