sunchao commented on a change in pull request #7666:
URL: https://github.com/apache/arrow/pull/7666#discussion_r452988944
##########
File path: rust/datafusion/src/execution/physical_plan/common.rs
##########
@@ -47,12 +47,12 @@ impl RecordBatchIterator {
}
}
-impl BatchIterator for RecordBatchIterator {
+impl SendableRecordBatchReader for RecordBatchIterator {
fn schema(&self) -> Arc<Schema> {
Review comment:
I suggest we replace this with `SchemaRef` to hide underlying impl
details.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
