joosthooz commented on a change in pull request #12609:
URL: https://github.com/apache/arrow/pull/12609#discussion_r829912915
##########
File path: cpp/src/parquet/arrow/reader.cc
##########
@@ -270,6 +273,20 @@ class FileReaderImpl : public FileReader {
records_to_read +=
reader_->metadata()->RowGroup(row_group)->ColumnChunk(i)->num_values();
}
+#ifdef ARROW_WITH_OPENTELEMETRY
+ std::string column_name = reader_->metadata()->schema()->Column(i)->name();
+ std::string phys_type =
TypeToString(reader_->metadata()->schema()->Column(i)->physical_type());
+ auto span = ::arrow::internal::tracing::GetTracer()->GetCurrentSpan();
+ ::arrow::util::tracing::Span childspan;
+ ::arrow::util::tracing::Span parentspan;
+ parentspan.Set(::arrow::util::tracing::Span::Impl{span});
Review comment:
Looking at this again, it seems superfluous. I'll remove it and just
start a span the normal way. That should already take care of setting the
current span as the parent automatically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
