sanjibansg commented on a change in pull request #12530:
URL: https://github.com/apache/arrow/pull/12530#discussion_r830650343
##########
File path: cpp/src/arrow/filesystem/path_util.h
##########
@@ -30,13 +30,16 @@ namespace fs {
namespace internal {
constexpr char kSep = '/';
+constexpr char kFilenameSep = '_';
// Computations on abstract paths (not local paths with system-dependent
behaviour).
// Abstract paths are typically used in URIs.
// Split an abstract path into its individual components.
ARROW_EXPORT
-std::vector<std::string> SplitAbstractPath(const std::string& s);
+std::vector<std::string> SplitAbstractPath(util::string_view path, const char&
sep);
+ARROW_EXPORT
+std::vector<std::string> SplitAbstractPath(const std::string& path);
Review comment:
Redefined `SplitAbstractPath()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
