sanjibansg commented on a change in pull request #12530:
URL: https://github.com/apache/arrow/pull/12530#discussion_r830650524
##########
File path: cpp/src/arrow/filesystem/path_util.cc
##########
@@ -30,28 +30,23 @@ namespace internal {
// XXX How does this encode Windows UNC paths?
-std::vector<std::string> SplitAbstractPath(const std::string& path) {
+std::vector<std::string> SplitAbstractPath(util::string_view path, const char&
sep) {
std::vector<std::string> parts;
- auto v = util::string_view(path);
- // Strip trailing slash
- if (v.length() > 0 && v.back() == kSep) {
- v = v.substr(0, v.length() - 1);
- }
Review comment:
Redefined the `SplitAbstractPath()`, I think that should work, do we
need anymore changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
