sanjibansg commented on a change in pull request #12530:
URL: https://github.com/apache/arrow/pull/12530#discussion_r830650407
##########
File path: cpp/src/arrow/filesystem/path_util.h
##########
@@ -95,22 +98,22 @@ std::vector<std::string>
MinimalCreateDirSet(std::vector<std::string> dirs);
// Join the components of an abstract path.
template <class StringIt>
-std::string JoinAbstractPath(StringIt it, StringIt end) {
+std::string JoinAbstractPath(StringIt it, StringIt end, const char& sep =
kSep) {
std::string path;
for (; it != end; ++it) {
if (it->empty()) continue;
if (!path.empty()) {
- path += kSep;
+ path += sep;
}
path += *it;
}
return path;
}
template <class StringRange>
-std::string JoinAbstractPath(const StringRange& range) {
- return JoinAbstractPath(range.begin(), range.end());
+std::string JoinAbstractPath(const StringRange& range, const char& sep = kSep)
{
Review comment:
Made the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
