wjones127 commented on code in PR #12751:
URL: https://github.com/apache/arrow/pull/12751#discussion_r852181773
##########
r/tests/testthat/test-RecordBatch.R:
##########
@@ -513,6 +513,76 @@ test_that("record_batch() with different length arrays", {
expect_error(record_batch(a = 1:5, b = 1:6), msg)
})
+test_that("RecordBatch doesn't support rbind", {
+ expect_snapshot_error(
Review Comment:
On the plus side, they make it really easy to capture the whole error we
test against and show that in the PR diff. Dewey suggested we add this when
earlier in this PR we had found the errors were passing my regex test but were
actually wrong.
> apparently count the number of errors in the file to see what message this
particular call threw.
They are labelled with what test they are in, so you should only have to
count within a test (if there even are multiple snapshots per a test.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
