sanjibansg commented on code in PR #12977:
URL: https://github.com/apache/arrow/pull/12977#discussion_r857857993
##########
cpp/src/arrow/dataset/discovery.cc:
##########
@@ -278,8 +278,13 @@ Result<std::shared_ptr<Dataset>>
FileSystemDatasetFactory::Finish(FinishOptions
}
std::vector<std::shared_ptr<FileFragment>> fragments;
+ std::string fixed_path;
for (const auto& info : files_) {
- auto fixed_path = StripPrefixAndFilename(info.path(),
options_.partition_base_dir);
+ if (partitioning->type_name() == "filename") {
+ fixed_path = StripPrefix(info.path(), options_.partition_base_dir);
+ } else {
+ fixed_path = StripPrefixAndFilename(info.path(),
options_.partition_base_dir);
+ }
Review Comment:
We may pass both the filename and the path(other than the prefix) to the
`Parse()` method, but the filename is only required for FilenamePartitioning I
believe, and the path will be required by the Directory & Hive Partitioning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
