sanjibansg commented on code in PR #12977:
URL: https://github.com/apache/arrow/pull/12977#discussion_r861963687
##########
cpp/src/arrow/dataset/partition.cc:
##########
@@ -805,19 +806,20 @@ std::shared_ptr<PartitioningFactory>
HivePartitioning::MakeFactory(
return std::shared_ptr<PartitioningFactory>(new
HivePartitioningFactory(options));
}
-std::string StripPrefixAndFilename(const std::string& path, const std::string&
prefix) {
+PartitionPathFormat StripPrefixAndFilename(const std::string& path,
+ const std::string& prefix) {
auto maybe_base_less = fs::internal::RemoveAncestor(prefix, path);
auto base_less = maybe_base_less ? std::string(*maybe_base_less) : path;
auto basename_filename = fs::internal::GetAbstractPathParent(base_less);
- return basename_filename.first;
+ return PartitionPathFormat{basename_filename.first,
basename_filename.second};
Review Comment:
Made the change, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
