sanjibansg commented on code in PR #12977:
URL: https://github.com/apache/arrow/pull/12977#discussion_r861963501
##########
cpp/src/arrow/dataset/partition.h:
##########
@@ -353,16 +359,17 @@ class ARROW_DS_EXPORT FilenamePartitioning : public
KeyValuePartitioning {
std::vector<std::string> field_names, PartitioningFactoryOptions = {});
private:
- Result<std::vector<Key>> ParseKeys(const std::string& path) const override;
+ Result<std::vector<Key>> ParseKeys(const std::string& directory,
+ const std::string& prefix) const override;
Result<PartitionPathFormat> FormatValues(const ScalarVector& values) const
override;
};
/// \brief Remove a prefix and the filename of a path.
///
/// e.g., `StripPrefixAndFilename("/data/year=2019/c.txt", "/data") ->
"year=2019"`
Review Comment:
Updated the docstring
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
