emkornfield commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r482714047
########## File path: cpp/src/parquet/kms_client.h ########## @@ -0,0 +1,81 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include <string> +#include <unordered_map> +#include <vector> + +#include "parquet/exception.h" +#include "parquet/platform.h" + +namespace parquet { +namespace encryption { + +class PARQUET_EXPORT KeyAccessToken { + public: + KeyAccessToken() = default; + + explicit KeyAccessToken(const std::string value) : value_(value) {} + + void Refresh(const std::string& new_value) { value_ = new_value; } + + const std::string& value() const { return value_; } + + void SetDefaultIfEmpty(); + + private: + std::string value_; +}; + +struct PARQUET_EXPORT KmsConnectionConfig { + std::string kms_instance_id; + std::string kms_instance_url; + std::shared_ptr<KeyAccessToken> refreshable_key_access_token; + std::unordered_map<std::string, std::string> custom_kms_conf; + + const std::string& key_access_token() const { + if (refreshable_key_access_token == NULL || + refreshable_key_access_token->value().empty()) { + throw ParquetException("key access token is not set!"); + } + return refreshable_key_access_token->value(); + } + + void SetDefaultIfEmpty(); +}; + +class PARQUET_EXPORT KmsClient { + public: + static constexpr char KMS_INSTANCE_ID_DEFAULT[] = "DEFAULT"; + static constexpr char KMS_INSTANCE_URL_DEFAULT[] = "DEFAULT"; + static constexpr char KEY_ACCESS_TOKEN_DEFAULT[] = "DEFAULT"; + + // Wraps a key - encrypts it with the master key, encodes the result + // and potentially adds a KMS-specific metadata. + virtual std::string WrapKey(const std::string& key_bytes, + const std::string& master_key_identifier) = 0; Review comment: I haven't reviewed the other encryption code (or the java portion of this code but I would have the same feedback on the Java API if almost all of the API was passing around strings that have different semantic meanings. It is easy to confuse order of parameters, etc. I've seen not great results cargo-culting between Java and C++. Unless this is for the express purposes of JNI don't think should necessarily be a goal. in this case with only two parameters it might be OK. But it seems like it is potentially easy to confuse. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
