thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r483013904
########## File path: cpp/src/parquet/file_key_wrapper.h ########## @@ -0,0 +1,68 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include <map> +#include <memory> +#include <string> + +#include "parquet/file_key_material_store.h" +#include "parquet/key_encryption_key.h" +#include "parquet/kms_client.h" +#include "parquet/kms_client_factory.h" + +namespace parquet { +namespace encryption { + +class FileKeyWrapper { + public: + static constexpr int KEK_LENGTH = 16; + static constexpr int KEK_ID_LENGTH = 16; + + static constexpr int RND_MAX_BYTES = 32; + + FileKeyWrapper(std::shared_ptr<KmsClientFactory> kms_client_factory, + const KmsConnectionConfig& kms_connection_config, + std::shared_ptr<FileKeyMaterialStore> key_material_store, + uint64_t cache_entry_lifetime, bool double_wrapping, + bool is_wrap_locally); + + std::string GetEncryptionKeyMetadata(const std::string& data_key, Review comment: Since we already have a struct KeyMetadata, so creating one more struct to contain this string doesn't make sense. We can change it to: ``` KeyMetadata FileKeyWrapper::GetEncryptionKeyMetadata(...) ``` and create a method: ``` std::string KeyMetadata::SerializeToJson() ``` But it seems not a reversed step of `std::string FileKeyWrapper::GetKey(const std::string& key_metadata) const`. So I still prefer current approach. cc @ggershinsky. ########## File path: cpp/src/parquet/file_key_wrapper.h ########## @@ -0,0 +1,68 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include <map> +#include <memory> +#include <string> + +#include "parquet/file_key_material_store.h" +#include "parquet/key_encryption_key.h" +#include "parquet/kms_client.h" +#include "parquet/kms_client_factory.h" + +namespace parquet { +namespace encryption { + +class FileKeyWrapper { + public: + static constexpr int KEK_LENGTH = 16; + static constexpr int KEK_ID_LENGTH = 16; + + static constexpr int RND_MAX_BYTES = 32; + + FileKeyWrapper(std::shared_ptr<KmsClientFactory> kms_client_factory, + const KmsConnectionConfig& kms_connection_config, + std::shared_ptr<FileKeyMaterialStore> key_material_store, + uint64_t cache_entry_lifetime, bool double_wrapping, + bool is_wrap_locally); + + std::string GetEncryptionKeyMetadata(const std::string& data_key, Review comment: @emkornfield Since we already have a struct KeyMetadata, so creating one more struct to contain this string doesn't make sense. We can change it to: ``` KeyMetadata FileKeyWrapper::GetEncryptionKeyMetadata(...) ``` and create a method: ``` std::string KeyMetadata::SerializeToJson() ``` But it seems not a reversed step of `std::string FileKeyWrapper::GetKey(const std::string& key_metadata) const`. So I still prefer current approach. cc @ggershinsky. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
