nealrichardson commented on code in PR #13170:
URL: https://github.com/apache/arrow/pull/13170#discussion_r875981109
##########
r/R/dplyr-collect.R:
##########
@@ -27,15 +27,31 @@ collect.arrow_dplyr_query <- function(x, as_data_frame =
TRUE, ...) {
}
# See query-engine.R for ExecPlan/Nodes
+ plan <- ExecPlan$create()
+ final_node <- plan$Build(x)
tryCatch(
- tab <- do_exec_plan(x),
+ tab <- plan$Run(final_node)$read_table(),
# n = 4 because we want the error to show up as being from collect()
# and not handle_csv_read_error()
error = function(e, call = caller_env(n = 4)) {
handle_csv_read_error(e, x$.data$schema, call)
}
)
+ # TODO: SinkNodeOptions need to take KVM like WriteNodeOptions
+ # or need to be able to set metadata on RBR
Review Comment:
```suggestion
# TODO(ARROW-16607): move KVM handling into ExecPlan
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
