nealrichardson commented on code in PR #13170:
URL: https://github.com/apache/arrow/pull/13170#discussion_r876424751
##########
r/R/dataset-scan.R:
##########
@@ -214,13 +228,7 @@ map_batches <- function(X, FUN, ..., .data.frame = TRUE) {
res <- res[seq_len(i)]
}
- if (.data.frame & inherits(res[[1]], "arrow_dplyr_query")) {
- res <- dplyr::bind_rows(map(res, dplyr::collect))
- } else if (.data.frame) {
- res <- dplyr::bind_rows(map(res, as.data.frame))
- }
-
- res
+ as_adq(RecordBatchReader$create(batches = res))
Review Comment:
I was thinking back to the discussion that ARROW-15489 refers to, where RBR
didn't print usefully so it would be weird to get one back. But now that that
issue has been done, you're right, RBR makes sense (it prints about the same as
ADQ now). I can switch this one and also switch the duckdb to_arrow() one as
well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
