tustvold commented on code in PR #2578:
URL: https://github.com/apache/arrow-datafusion/pull/2578#discussion_r877009325
##########
ballista/rust/core/src/serde/physical_plan/mod.rs:
##########
@@ -1029,14 +1029,10 @@ fn decode_scan_config(
.map(|f| f.try_into())
.collect::<Result<Vec<_>, _>>()?;
- let object_store = if let Some(file) = file_groups.get(0).and_then(|h|
h.get(0)) {
- runtime.object_store(file.file_meta.path())?.0
- } else {
- Arc::new(LocalFileSystem {})
- };
+ // TODO: This will not roundtrip object storage correctly as it loses the
scheme
Review Comment:
I'm not really sure how to handle this, as at this point the scheme has been
stripped from the paths. I suspect something else needs to be encoded in
FileScanExecConf - but I'm not very familiar with this code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
