tustvold commented on code in PR #2578:
URL: https://github.com/apache/arrow-datafusion/pull/2578#discussion_r877048813
##########
ballista/rust/core/src/serde/physical_plan/mod.rs:
##########
@@ -1029,14 +1029,10 @@ fn decode_scan_config(
.map(|f| f.try_into())
.collect::<Result<Vec<_>, _>>()?;
- let object_store = if let Some(file) = file_groups.get(0).and_then(|h|
h.get(0)) {
- runtime.object_store(file.file_meta.path())?.0
- } else {
- Arc::new(LocalFileSystem {})
- };
+ // TODO: This will not roundtrip object storage correctly as it loses the
scheme
Review Comment:
Yeah, I think it should probably round-trip scheme and host explicitly and
use this to determine the object store. Currently ObjectStoreRegistry doesn't
handle host consistently, but its something that I intend to fix soon so would
be good to cover it as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
