tustvold commented on code in PR #2578:
URL: https://github.com/apache/arrow-datafusion/pull/2578#discussion_r883601666
##########
datafusion/core/Cargo.toml:
##########
@@ -85,6 +87,7 @@ sqlparser = "0.17"
tempfile = "3"
tokio = { version = "1.0", features = ["macros", "rt", "rt-multi-thread",
"sync", "fs", "parking_lot"] }
tokio-stream = "0.1"
+url = "2.2"
Review Comment:
This is a new dependency, it is brought in by hyper and friends and so again
is pretty ubiquitous
##########
datafusion/core/Cargo.toml:
##########
@@ -67,7 +67,9 @@ datafusion-physical-expr = { path = "../physical-expr",
version = "8.0.0" }
datafusion-row = { path = "../row", version = "8.0.0" }
datafusion-sql = { path = "../sql", version = "8.0.0" }
futures = "0.3"
+glob = "0.3.0"
Review Comment:
This is moved from data_access
##########
datafusion/core/Cargo.toml:
##########
@@ -67,7 +67,9 @@ datafusion-physical-expr = { path = "../physical-expr",
version = "8.0.0" }
datafusion-row = { path = "../row", version = "8.0.0" }
datafusion-sql = { path = "../sql", version = "8.0.0" }
futures = "0.3"
+glob = "0.3.0"
hashbrown = { version = "0.12", features = ["raw"] }
+itertools = "0.10"
Review Comment:
This is technically a new dependency of this crate, but it is so ubiquitous
and is a dependency of prost, etc.. so this is probably ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
