ming535 opened a new pull request, #2638: URL: https://github.com/apache/arrow-datafusion/pull/2638
# Which issue does this PR close? Closes https://github.com/apache/arrow-datafusion/issues/2624 # Rationale for this change See below. # What changes are included in this PR? 1. When SqlToRel build the plan, `Limit` should be the parent of `Offset`, according to https://www.postgresql.org/docs/current/queries-limit.html (If both OFFSET and LIMIT appear, then OFFSET rows are skipped before starting to count the LIMIT rows that are returned.) 3. fix limit_push_down to consider every combination of `Offset` and `Limit` when traversing down the plan tree. # Are there any user-facing changes? The semantic of LogicalPlan#offset, and LogicalPlan#limit is different. Previously, `builder.limit(100).offset(10)` means ignore the first 10 rows and then starting to count 100 rows. Now it means returns 100 rows and then skip 10 rows. The current semantic is consistent with how data is flowing in the plan tree. # Does this PR break compatibility with Ballista? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
