andygrove commented on PR #2638: URL: https://github.com/apache/arrow-datafusion/pull/2638#issuecomment-1144000155
> Yes. The current design of plan builder tries to mimics the semantics of SQL language; this PR tries to mimics the tree structure of logical operator. > > We can add another api for the builder to combines `limit` and `offset` to mimics SQL language. For example: `fetch(offset: Option<usize>, limit: Option<usize>)` I wonder if we should consider renaming the `DataFrame` / `LogicalPlanBuilder` methods. The terms limit and offset are very SQL-specific and not so intuitive here and I think that adds to confusion about how they might be interpreted. Perhaps we should consider renaming `offset` to `drop` for example. That would be closer to pandas based on a quick look at the documentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
