ming535 commented on PR #2638: URL: https://github.com/apache/arrow-datafusion/pull/2638#issuecomment-1140797256
> > builder.limit(100).offset(10) means ignore the first 10 rows and then starting to count 100 rows. Now it > > means returns 100 rows and then skip 10 rows. > > @ming535 If this happened, means only return 90 rows? Yes. The current design of plan builder tries to mimics the semantics of SQL language; this PR tries to mimics the tree structure of logical operator. We can add another api for the builder to combines `limit` and `offset` to mimics SQL language. For example: `fetch(offset: Option<usize>, limit: Option<usize>)` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
