tustvold commented on code in PR #1762:
URL: https://github.com/apache/arrow-rs/pull/1762#discussion_r885062214
##########
parquet/src/file/metadata.rs:
##########
@@ -60,6 +63,21 @@ impl ParquetMetaData {
ParquetMetaData {
file_metadata,
row_groups,
+ page_indexes: None,
+ offset_indexes: None,
+ }
+ }
+
+ pub fn new_with_page_index(
+ metadata: ParquetMetaData,
+ page_indexes: Option<Vec<Arc<dyn Index>>>,
+ offset_indexes: Option<Vec<Vec<PageLocation>>>,
Review Comment:
> Or maybe like construct new offsetIndex in next Pr.
Precisely this, they're interconnected data structures which imo make sense
to encapsulate together, happy for this to left for a subsequent PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
