Ted-Jiang commented on code in PR #1762:
URL: https://github.com/apache/arrow-rs/pull/1762#discussion_r885434888
##########
parquet/src/data_type.rs:
##########
@@ -1194,8 +1196,8 @@ make_type!(
impl FromBytes for Int96 {
type Buffer = [u8; 12];
- fn from_le_bytes(_bs: Self::Buffer) -> Self {
- unimplemented!()
+ fn from_le_bytes(bs: Self::Buffer) -> Self {
+ Self::from_ne_bytes(bs)
Review Comment:
I am not familiar with this, is this
[2b5264b](https://github.com/apache/arrow-rs/pull/1762/commits/2b5264ba6898faeab88d9d42df973cc4d3c5b0ee)
, how should i test this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
