tustvold commented on code in PR #1762:
URL: https://github.com/apache/arrow-rs/pull/1762#discussion_r885341514
##########
parquet/src/data_type.rs:
##########
@@ -1194,8 +1196,8 @@ make_type!(
impl FromBytes for Int96 {
type Buffer = [u8; 12];
- fn from_le_bytes(_bs: Self::Buffer) -> Self {
- unimplemented!()
+ fn from_le_bytes(bs: Self::Buffer) -> Self {
+ Self::from_ne_bytes(bs)
Review Comment:
This will be incorrect on any platform that isn't little endian...
##########
parquet/src/data_type.rs:
##########
@@ -591,6 +591,8 @@ pub(crate) mod private {
+ super::SliceAsBytes
+ PartialOrd
+ Send
+ + Sync
Review Comment:
I can't see why this change was made, it's fine, but it seems unnecessary
##########
parquet/src/file/page_index/index_reader.rs:
##########
@@ -0,0 +1,169 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+use crate::basic::Type;
+use crate::data_type::Int96;
+use crate::errors::ParquetError;
+use crate::file::metadata::ColumnChunkMetaData;
+use crate::file::page_index::index::{BooleanIndex, ByteIndex, Index,
NativeIndex};
+use crate::file::reader::ChunkReader;
+use parquet_format::{ColumnIndex, OffsetIndex, PageLocation};
+use std::io::{Cursor, Read};
+use std::sync::Arc;
+use thrift::protocol::TCompactInputProtocol;
+
+/// Read on row group's all columns indexes and change into [`Index`]
+/// If not the format not available return an empty vector.
+pub fn read_columns_indexes<R: ChunkReader>(
+ reader: &R,
+ chunks: &[ColumnChunkMetaData],
+) -> Result<Vec<Arc<dyn Index>>, ParquetError> {
+ let (offset, lengths) = get_index_offset_and_lengths(chunks)?;
+ let length = lengths.iter().sum::<usize>();
+
+ //read all need data into buffer
+ let mut reader = reader.get_read(offset, reader.len() as usize)?;
+ let mut data = vec![0; length];
+ reader.read_exact(&mut data)?;
+
+ let mut start = 0;
Review Comment:
But surely the thrift decoder will only read what it needs, i.e. regardless
of the variable length nature of the messages it will only read the
corresponding bytes? It's not a big deal, I just think we should consistently
either rely on the data to be "self-delimiting" or use the lengths to decode
slices
##########
parquet/src/file/page_index/index.rs:
##########
@@ -0,0 +1,209 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+use crate::basic::Type;
+use crate::data_type::private::ParquetValueType;
+use crate::data_type::Int96;
+use crate::errors::ParquetError;
+use crate::util::bit_util::from_ne_slice;
+use parquet_format::{BoundaryOrder, ColumnIndex};
+use std::fmt::Debug;
+
+/// The statistics in one page
+#[derive(Debug, Clone, PartialEq, Eq, Hash)]
+pub struct PageIndex<T> {
+ /// The minimum value, It is None when all values are null
+ pub min: Option<T>,
+ /// The maximum value, It is None when all values are null
+ pub max: Option<T>,
+ /// Null values in the page
+ pub null_count: Option<i64>,
+}
+
+impl<T> PageIndex<T> {
+ pub fn min(&self) -> Option<&T> {
+ self.min.as_ref()
+ }
+ pub fn max(&self) -> Option<&T> {
+ self.max.as_ref()
+ }
+ pub fn null_count(&self) -> Option<i64> {
+ self.null_count
+ }
+}
+
+#[derive(Debug, Clone, PartialEq)]
+pub enum Index {
+ BOOLEAN(BooleanIndex),
Review Comment:
Fair, I mean to change that but it has been low on my priority list 😅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
