sanjibansg commented on code in PR #13285:
URL: https://github.com/apache/arrow/pull/13285#discussion_r890823220
##########
cpp/src/arrow/engine/substrait/extension_set.h:
##########
@@ -22,16 +22,55 @@
#include <unordered_map>
#include <vector>
+#include "arrow/compute/function.h"
+#include "arrow/compute/exec/expression.h"
#include "arrow/engine/substrait/visibility.h"
#include "arrow/type_fwd.h"
#include "arrow/util/optional.h"
#include "arrow/util/string_view.h"
#include "arrow/util/hash_util.h"
+#include "substrait/expression.pb.h" // IWYU pragma: export
namespace arrow {
namespace engine {
+class ExtensionSet;
+using ArrowToSubstrait =
std::function<Result<substrait::Expression::ScalarFunction>(const
arrow::compute::Expression::Call&, arrow::engine::ExtensionSet*)>;
+using SubstraitToArrow =
std::function<Result<arrow::compute::Expression>(const
substrait::Expression::ScalarFunction&)>;
+
+class FunctionMapping {
+
+ enum defined_functions {
Review Comment:
Removed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
