[GitHub] [arrow] sanjibansg commented on a diff in pull request #13285: ARROW-15582: [C++] Add support for registering tricky functions with the Substrait consumer (or add a bunch of substrait meta functions)

[GitBox]

sanjibansg commented on code in PR #13285:
URL: https://github.com/apache/arrow/pull/13285#discussion_r890823472


##########
cpp/src/arrow/engine/substrait/extension_set.cc:
##########
@@ -351,5 +355,278 @@ ExtensionIdRegistry* default_extension_id_registry() {
   return &impl_;
 }
 
+Status FunctionMapping::AddArrowToSubstrait(std::string arrow_function_name, 
ArrowToSubstrait conversion_func){
+  if (arrow_to_substrait.find(arrow_function_name) != 
arrow_to_substrait.end()){
+    arrow_to_substrait[arrow_function_name] =  conversion_func;
+  }

Review Comment:
   Returning an AlreadyExist status.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org