[GitHub] [arrow] sanjibansg commented on a diff in pull request #13285: ARROW-15582: [C++] Add support for registering tricky functions with the Substrait consumer (or add a bunch of substrait meta functions)

[GitBox]

sanjibansg commented on code in PR #13285:
URL: https://github.com/apache/arrow/pull/13285#discussion_r890823834


##########
cpp/src/arrow/engine/substrait/expression_internal.cc:
##########
@@ -159,21 +159,11 @@ Result<compute::Expression> FromProto(const 
substrait::Expression& expr,
 
       ARROW_ASSIGN_OR_RAISE(auto decoded_function,
                             
ext_set.DecodeFunction(scalar_fn.function_reference()));
+      
+      auto arrow_function = 
ext_set.GetFunctionMap().GetArrowFromSubstrait(decoded_function.name.to_string());
 
-      std::vector<compute::Expression> arguments(scalar_fn.args_size());
-      for (int i = 0; i < scalar_fn.args_size(); ++i) {
-        ARROW_ASSIGN_OR_RAISE(arguments[i], FromProto(scalar_fn.args(i), 
ext_set));
-      }
+      return arrow_function(scalar_fn);                      

Review Comment:
   Returning a KeyError status if not found.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org