wesm commented on code in PR #13364:
URL: https://github.com/apache/arrow/pull/13364#discussion_r895067365
##########
cpp/src/arrow/util/bitmap.h:
##########
@@ -53,27 +53,36 @@ class ARROW_EXPORT Bitmap : public
util::ToStringOstreamable<Bitmap>,
Bitmap() = default;
- Bitmap(std::shared_ptr<Buffer> buffer, int64_t offset, int64_t length)
- : buffer_(std::move(buffer)), offset_(offset), length_(length) {}
+ Bitmap(const std::shared_ptr<Buffer>& buffer, int64_t offset, int64_t length)
Review Comment:
I renamed BufferRef but leaving the Bitmap discussion for follow up
##########
cpp/src/arrow/compute/exec.h:
##########
@@ -252,6 +254,192 @@ struct ARROW_EXPORT ExecBatch {
inline bool operator==(const ExecBatch& l, const ExecBatch& r) { return
l.Equals(r); }
inline bool operator!=(const ExecBatch& l, const ExecBatch& r) { return
!l.Equals(r); }
+struct ExecValue {
Review Comment:
thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
