drin commented on code in PR #13383:
URL: https://github.com/apache/arrow/pull/13383#discussion_r897527445
##########
cpp/src/arrow/record_batch.cc:
##########
@@ -393,7 +393,7 @@ Result<std::shared_ptr<RecordBatchReader>>
RecordBatchReader::Make(
RecordBatchReader::~RecordBatchReader() {
auto st = this->Close();
if (!st.ok()) {
- ARROW_LOG(WARNING) << "Implicitly called RecordBatchReader::Close failed:
" << st;
Review Comment:
I mostly wanted to maintain the message that was already there. But
otherwise the message is meant to convey that Close was called implicitly (user
did not explicitly close the reader) and that the status was non-successful.
I could change it but I don't have strong opinions on what would be better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
