drin commented on code in PR #13383:
URL: https://github.com/apache/arrow/pull/13383#discussion_r898008205
##########
cpp/src/arrow/status.cc:
##########
@@ -134,9 +134,8 @@ void Status::Abort(const std::string& message) const {
void Status::Warn() const { Warn(std::string()); }
void Status::Warn(const std::string& message) const {
- ARROW_LOG(WARNING) << "-- Arrow Warning --"
- << message << "\n"
- << ToString() << "\n";
+ ARROW_LOG(WARNING) << "-- Arrow Warning --\n"
+ << message << "\n" << ToString();
Review Comment:
maybe I should remove the "\n" and replace with ": "?
I also kept the header (`-- Arrow Warning --`) in the same style as the
abort message, but maybe it'd be nice to change it to `[Arrow Warning] -- ` and
then remove that newline as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
