drin commented on code in PR #13383:
URL: https://github.com/apache/arrow/pull/13383#discussion_r897999493
##########
cpp/src/arrow/status.cc:
##########
@@ -131,6 +131,17 @@ void Status::Abort(const std::string& message) const {
std::abort();
}
+void Status::Warn() const { Warn(std::string()); }
+
+void Status::Warn(const std::string& message) const {
+ ARROW_LOG(WARNING) << "-- Arrow Warning --";
+ if (!message.empty()) {
+ ARROW_LOG(WARNING) << message;
+ }
+
+ ARROW_LOG(WARNING) << ToString() << "\n";
Review Comment:
I liked these suggestions, but I figured it'd be better to go ahead and
combine all of them. Since it seems like this comment becomes a hanging
comment, this is what I changed the code to:
```cpp
ARROW_LOG(WARNING) << "-- Arrow Warning --\n"
<< message << "\n" << ToString();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
