nealrichardson commented on code in PR #13404:
URL: https://github.com/apache/arrow/pull/13404#discussion_r906801722
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -4046,25 +4054,47 @@ macro(build_google_cloud_cpp_storage)
"${GOOGLE_CLOUD_CPP_STATIC_LIBRARY_COMMON}"
INTERFACE_INCLUDE_DIRECTORIES
"${GOOGLE_CLOUD_CPP_INCLUDE_DIR}")
+ # Refer to
https://github.com/googleapis/google-cloud-cpp/blob/main/google/cloud/google_cloud_cpp_common.cmake
+ # (subsitute `main` for the SHA of the version we use)
+ # Version 1.39.0 is at a different place (they refactored after):
+ #
https://github.com/googleapis/google-cloud-cpp/blob/29e5af8ca9b26cec62106d189b50549f4dc1c598/google/cloud/CMakeLists.txt#L146-L155
set_property(TARGET google-cloud-cpp::common
PROPERTY INTERFACE_LINK_LIBRARIES
- absl::any
- absl::flat_hash_map
+ absl::base
absl::memory
absl::optional
+ absl::span
absl::time
+ absl::variant
Threads::Threads
OpenSSL::Crypto)
+ add_library(google-cloud-cpp::rest-internal STATIC IMPORTED)
+ set_target_properties(google-cloud-cpp::rest-internal
+ PROPERTIES IMPORTED_LOCATION
+
"${GOOGLE_CLOUD_CPP_STATIC_LIBRARY_REST_INTERNAL}"
+ INTERFACE_INCLUDE_DIRECTORIES
+ "${GOOGLE_CLOUD_CPP_INCLUDE_DIR}")
+ set_property(TARGET google-cloud-cpp::rest-internal
+ PROPERTY INTERFACE_LINK_LIBRARIES
+ absl::span
+ google-cloud-cpp::common
+ CURL::libcurl
+ nlohmann_json::nlohmann_json
+ OpenSSL::SSL
+ OpenSSL::Crypto)
+
add_library(google-cloud-cpp::storage STATIC IMPORTED)
set_target_properties(google-cloud-cpp::storage
PROPERTIES IMPORTED_LOCATION
"${GOOGLE_CLOUD_CPP_STATIC_LIBRARY_STORAGE}"
INTERFACE_INCLUDE_DIRECTORIES
"${GOOGLE_CLOUD_CPP_INCLUDE_DIR}")
+ # Update this from
https://github.com/googleapis/google-cloud-cpp/blob/main/google/cloud/storage/google_cloud_cpp_storage.cmake
set_property(TARGET google-cloud-cpp::storage
PROPERTY INTERFACE_LINK_LIBRARIES
google-cloud-cpp::common
Review Comment:
I guess so, but since it's copied from upstream, I'd rather leave it there
for completeness unless it's harming anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
