nealrichardson commented on code in PR #13404:
URL: https://github.com/apache/arrow/pull/13404#discussion_r906803022
##########
r/configure:
##########
@@ -229,44 +229,48 @@ if [ $? -eq 0 ]; then
# Check for features
LIB_DIR=`echo $PKG_DIRS | sed -e 's/^-L//'`
ARROW_OPTS_CMAKE="$LIB_DIR/cmake/arrow/ArrowOptions.cmake"
- # Check for Parquet
- grep -i 'set(ARROW_PARQUET "ON")' $ARROW_OPTS_CMAKE >/dev/null 2>&1
- if [ $? -eq 0 ]; then
+
+ arrow_built_with() {
+ # Function to check cmake options for features
+ grep -i 'set('"$1"' "ON")' $ARROW_OPTS_CMAKE >/dev/null 2>&1
Review Comment:
`grep -q` doesn't suppress stderr though, and I want this to be completely
silent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
