thisisnic commented on code in PR #13514:
URL: https://github.com/apache/arrow/pull/13514#discussion_r913807354
##########
r/src/dataset.cpp:
##########
@@ -511,8 +511,8 @@ std::shared_ptr<arrow::Table> dataset___Scanner__TakeRows(
}
// [[dataset::export]]
-int64_t dataset___Scanner__CountRows(const std::shared_ptr<ds::Scanner>&
scanner) {
- return ValueOrStop(scanner->CountRows());
+r_vec_size dataset___Scanner__CountRows(const std::shared_ptr<ds::Scanner>&
scanner) {
+ return r_vec_size(ValueOrStop(scanner->CountRows()));
Review Comment:
Wasn't sure if this should be `r_vec_size(ValueOrStop...` or
`ValueOrStop(r_vec_size...`, though I'm not sure if it makes any practical
difference?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
