nealrichardson commented on PR #13514: URL: https://github.com/apache/arrow/pull/13514#issuecomment-1178223839
> > I don't see a test of the r_vec_size() behavior in this PR or the other one. What is our assurance that it behaves as we want? > > I added some in an earlier version of the previous PR, but they took ages to run locally (though were successful), and on CI just crashed it entirely. I removed them, but couldn't think of an alternative. Do you have any suggestions? > You could tack onto one of the tests that is guarded by `ARROW_LARGE_MEMORY_TESTS`. Those create buffers that are >2GB and require Large types, which means their size exceeds MAX_INT32 bytes. So check that the buffer size doesn't overflow and is `double`? I think buffer size was one of the other cases that returned int64_t that you would have find/replaced here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
