rok commented on code in PR #13539:
URL: https://github.com/apache/arrow/pull/13539#discussion_r915823880
##########
cpp/src/arrow/compute/kernels/scalar_temporal_test.cc:
##########
@@ -3572,5 +3572,34 @@ TEST_F(ScalarTemporalTest,
TestCeilFloorRoundTemporalKolkata) {
CheckScalarUnary("round_temporal", unit, times, unit, round_2_hours,
&round_to_2_hours);
}
+TEST_F(ScalarTemporalTest, TestCeilFloorRoundTemporalDate) {
+ RoundTemporalOptions round_to_2_hours = RoundTemporalOptions(2,
CalendarUnit::HOUR);
+ const char* date32s = R"([0, 11016, -25932, null])";
+ const char* date64s = R"([0, 951782400000, -2240524800000, null])";
+ auto dates32 = ArrayFromJSON(date32(), date32s);
+ auto dates64 = ArrayFromJSON(date64(), date64s);
+
+ CheckScalarUnary("ceil_temporal", dates32, dates32, &round_to_2_hours);
+ CheckScalarUnary("floor_temporal", dates32, dates32, &round_to_2_hours);
+ CheckScalarUnary("round_temporal", dates32, dates32, &round_to_2_hours);
Review Comment:
```
Expected:
[
1970-01-01,
2000-02-29,
1899-01-01,
null
]
Actual:
[
1970-01-01,
1970-01-01,
2000-02-29,
null
]
```
##########
cpp/src/arrow/compute/kernels/scalar_temporal_test.cc:
##########
@@ -3572,5 +3572,34 @@ TEST_F(ScalarTemporalTest,
TestCeilFloorRoundTemporalKolkata) {
CheckScalarUnary("round_temporal", unit, times, unit, round_2_hours,
&round_to_2_hours);
}
+TEST_F(ScalarTemporalTest, TestCeilFloorRoundTemporalDate) {
+ RoundTemporalOptions round_to_2_hours = RoundTemporalOptions(2,
CalendarUnit::HOUR);
+ const char* date32s = R"([0, 11016, -25932, null])";
+ const char* date64s = R"([0, 951782400000, -2240524800000, null])";
+ auto dates32 = ArrayFromJSON(date32(), date32s);
+ auto dates64 = ArrayFromJSON(date64(), date64s);
+
+ CheckScalarUnary("ceil_temporal", dates32, dates32, &round_to_2_hours);
+ CheckScalarUnary("floor_temporal", dates32, dates32, &round_to_2_hours);
+ CheckScalarUnary("round_temporal", dates32, dates32, &round_to_2_hours);
+ CheckScalarUnary("ceil_temporal", dates64, dates64, &round_to_2_hours);
+ CheckScalarUnary("floor_temporal", dates64, dates64, &round_to_2_hours);
+ CheckScalarUnary("round_temporal", dates64, dates64, &round_to_2_hours);
+
+ const char* times_s = R"([0, 7200, null])";
+ const char* times_ms = R"([0, 7200000, null])";
+ const char* times_us = R"([0, 7200000000, null])";
+ const char* times_ns = R"([0, 7200000000000, null])";
+ auto arr_s = ArrayFromJSON(time32(TimeUnit::SECOND), times_s);
+ auto arr_ms = ArrayFromJSON(time32(TimeUnit::MILLI), times_ms);
Review Comment:
```
Expected:
[
00:00:00.000,
02:00:00.000,
null
]
Actual:
[
00:00:00.000,
00:00:00.000,
null
]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
