lidavidm commented on code in PR #13539:
URL: https://github.com/apache/arrow/pull/13539#discussion_r916999149
##########
cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc:
##########
@@ -168,8 +168,8 @@ struct TemporalComponentExtractWeek
template <template <typename...> class Op, typename Duration, typename InType,
typename OutType>
struct TemporalComponentExtractRound
- : public TemporalComponentExtractBase<Op, Duration, InType, OutType> {
- using Base = TemporalComponentExtractBase<Op, Duration, InType, OutType>;
+ : public TemporalComponentExtractBase<Op, Duration, InType, InType> {
+ using Base = TemporalComponentExtractBase<Op, Duration, InType, InType>;
Review Comment:
This looks a little odd…it's because UnaryTemporalFactory is designed for
functions which have a single consistent output type? May be worth noting down
below in the registration section that the output type passed to the factory is
ignored
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
