alamb commented on code in PR #2906:
URL: https://github.com/apache/arrow-datafusion/pull/2906#discussion_r922083162
##########
datafusion/core/src/datasource/object_store.rs:
##########
@@ -81,10 +81,19 @@ impl std::fmt::Display for ObjectStoreUrl {
}
}
+/// Object store self detector can detector an object store based on the url
Review Comment:
```suggestion
/// Object store self detector can detector an object store based on the url
///
/// This supports the usecase of providing [`ObjectStore`] instances based
on different hosts
// (such as `hdfs://10.10.0.1` and `hdfs://10.10.0.2` which might have
different access access credentials)?
Correct, we only pass the URL path to ObjectStore, and not any authority
(host, port, credentials, etc...).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
