yahoNanJing commented on code in PR #2906: URL: https://github.com/apache/arrow-datafusion/pull/2906#discussion_r922179405
########## datafusion/core/src/datasource/object_store.rs: ########## @@ -81,10 +81,19 @@ impl std::fmt::Display for ObjectStoreUrl { } } +/// Object store self detector can detector an object store based on the url +pub trait ObjectStoreSelfDetector: Send + Sync + 'static { Review Comment: Actually it's based on the url rather than the scheme. How about just rename it to be ObjectStoreProvider -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org