yahoNanJing commented on code in PR #2906:
URL: https://github.com/apache/arrow-datafusion/pull/2906#discussion_r922463312
##########
datafusion/core/src/datasource/object_store.rs:
##########
@@ -132,19 +149,51 @@ impl ObjectStoreRegistry {
///
/// - URL with scheme `file:///` or no schema will return the default
LocalFS store
/// - URL with scheme `s3://bucket/` will return the S3 store if it's
registered
+ /// - URL with scheme `hdfs://hostname:port` will return the hdfs store if
it's registered
///
pub fn get_by_url(&self, url: impl AsRef<Url>) -> Result<Arc<dyn
ObjectStore>> {
let url = url.as_ref();
- let s = &url[url::Position::BeforeScheme..url::Position::AfterHost];
- let stores = self.object_stores.read();
- let store = stores.get(s).ok_or_else(|| {
- DataFusionError::Internal(format!(
- "No suitable object store found for {}",
- url
- ))
- })?;
-
- Ok(store.clone())
+ // First check whether can get object store from registry
+ let store = {
+ let stores = self.object_stores.read();
+ let s =
&url[url::Position::BeforeScheme..url::Position::BeforeHost];
Review Comment:
Actually the reason why it becomes complex is because the object_store
changes the behavior and it's no longer based on the scheme any more. And we
have to deal with complex parsing for different object stores.
The self-detector feature based on its url is a necessary feature for the
ballista. However, manually registration is also a necessary feature for the
datafusion, right? We still need to deal with different kinds of object stores
in the datafusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
