wesm commented on code in PR #13630:
URL: https://github.com/apache/arrow/pull/13630#discussion_r924503273
##########
cpp/src/arrow/compute/exec_internal.h:
##########
@@ -84,7 +51,10 @@ class ARROW_EXPORT ExecSpanIterator {
/// \param[in] batch the input ExecBatch
/// \param[in] max_chunksize the maximum length of each ExecSpan. Depending
/// on the chunk layout of ChunkedArray.
- Status Init(const ExecBatch& batch, int64_t max_chunksize =
kDefaultMaxChunksize);
+ /// \param[in] promote_if_all_scalars if all of the values are scalars,
+ /// return them in each ExecSpan as ArraySpan of length 1
Review Comment:
I'm adding a comment that it should be set to true for scalar/vector
executors and false for scalar/hash aggregation execution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
