wesm commented on code in PR #13630:
URL: https://github.com/apache/arrow/pull/13630#discussion_r924506361
##########
cpp/src/arrow/compute/kernels/aggregate_basic_internal.h:
##########
@@ -448,9 +449,12 @@ struct MinMaxImpl : public ScalarAggregator {
return Status::OK();
}
- Status ConsumeArray(const ArrayType& arr) {
+ Status ConsumeArray(const ArraySpan& arr_span) {
StateType local;
+ // TODO(wesm): do not use ToArrayData
+ ArrayType arr(arr_span.ToArrayData());
Review Comment:
It can be done later, non-urgently. The span has to be "boxed" in order to
use `ArrayType::GetView`, but we could make that unnecessary in a subsequent
PR. I'm removing the TODO comment since usages of `ToArrayData` can be found
easily
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
