wesm commented on code in PR #13630:
URL: https://github.com/apache/arrow/pull/13630#discussion_r924508277
##########
cpp/src/arrow/compute/kernels/hash_aggregate_test.cc:
##########
@@ -202,14 +202,16 @@ Result<Datum> GroupByUsingExecPlan(const
std::vector<Datum>& arguments,
inputs.reserve(inputs.size() + keys.size());
inputs.insert(inputs.end(), keys.begin(), keys.end());
- ARROW_ASSIGN_OR_RAISE(auto batch_iterator,
- ExecBatchIterator::Make(inputs,
ctx->exec_chunksize()));
+ ExecSpanIterator span_iterator;
+ ARROW_ASSIGN_OR_RAISE(auto batch, ExecBatch::Make(inputs));
+ RETURN_NOT_OK(span_iterator.Init(batch, ctx->exec_chunksize()));
BatchesWithSchema input;
input.schema = schema(std::move(scan_fields));
- ExecBatch batch;
- while (batch_iterator->Next(&batch)) {
- if (batch.length == 0) continue;
- input.batches.push_back(std::move(batch));
+ ExecSpan span;
+ while (span_iterator.Next(&span)) {
+ if (span.length == 0) continue;
+ // TODO(wesm): investigate possibility of ExecPlans using ExecSpan
Review Comment:
Removing this comment -- this is something we can tackle in more general
refactoring of the execution engine (to introduce a distinction between tasks
and morsels) in the future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
