rtpsw commented on PR #13783: URL: https://github.com/apache/arrow/pull/13783#issuecomment-1204310424
> It sounds like it would be better to document the existing predicates, rather than add new ones with different names. The existing set of predicates is both confusing and incomplete, so I'd argue for both documenting and adding predicates. I'm not sure what to do with the names, considering backwards compatibility, though. Suppose we agree that a predicate corresponding to `PrimitiveTypes` should be added, since `is_primitive` is not the one, what should be the name of this predicate? There should be some naming convention here; perhaps `*Types()` should have a corresponding `check_*(type)` predicate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
