lidavidm commented on PR #13783: URL: https://github.com/apache/arrow/pull/13783#issuecomment-1205178523
Note #13753 removes the `*Types()` anyways. I'm -1 on the PR as is, but I think we should add the missing `is_*(Type::type id)` functions, and I think it's fine to also add overloads that take `const DataType&`. (This is probably overkill, but those who rely on IDE autocompletion may also appreciate `Type::is_integer` etc.) "primitive" is hard to define and it depends on what the user is after. I might favor a set of more specific predicates like the ones we have for template metaprogramming, e.g. `has_c_type` (which I think is roughly what the proposed is_primitive is: NA and nested types don't have a C type, but binary-likes do). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
