westonpace commented on code in PR #13613:
URL: https://github.com/apache/arrow/pull/13613#discussion_r939013606
##########
cpp/src/arrow/engine/substrait/ext_test.cc:
##########
@@ -248,22 +257,22 @@ TEST(ExtensionIdRegistryTest, RegisterNestedFunctions) {
for (int i = 0; i < rounds; i++) {
auto registry1 = substrait::MakeExtensionIdRegistry();
- ASSERT_OK(registry1->CanRegisterFunction(id1, name1.to_string()));
- ASSERT_OK(registry1->RegisterFunction(id1, name1.to_string()));
+ ASSERT_OK(registry1->CanAddSubstraitCallToArrow(id1));
+ ASSERT_OK(registry1->AddSubstraitCallToArrow(id1, name1.to_string()));
Review Comment:
Ah, I see your point. I was just porting over an existing test and I think
both are probably ok so I think I'd prefer to leave it as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
