westonpace commented on code in PR #13613:
URL: https://github.com/apache/arrow/pull/13613#discussion_r939005782
##########
cpp/src/arrow/engine/substrait/serde_test.cc:
##########
@@ -732,10 +737,9 @@ TEST(Substrait, ExtensionSetFromPlan) {
EXPECT_EQ(decoded_null_type.id.name, "null");
EXPECT_EQ(*decoded_null_type.type, NullType());
- EXPECT_OK_AND_ASSIGN(auto decoded_add_func, ext_set.DecodeFunction(42));
- EXPECT_EQ(decoded_add_func.id.uri, kArrowExtTypesUri);
- EXPECT_EQ(decoded_add_func.id.name, "add");
- EXPECT_EQ(decoded_add_func.name, "add");
Review Comment:
`DecodeFunction` used to return an `Id` and an Arrow function name.
Returning only an Arrow function name was not sufficient. Now it only returns
an `Id`. The job was split into `DecodeFunction` (which the extension set
provides itself) and `GetSubstraitCallToArrow` (which the extension id registry
provides). So there is no `decoded_add_func.name` any longer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
