westonpace commented on code in PR #13613:
URL: https://github.com/apache/arrow/pull/13613#discussion_r939059671
##########
cpp/src/arrow/engine/substrait/expression_internal.cc:
##########
@@ -41,6 +41,84 @@ namespace internal {
using ::arrow::internal::make_unique;
} // namespace internal
+Status DecodeArg(const substrait::FunctionArgument& arg, int idx,
SubstraitCall* call,
Review Comment:
I think I was originally aiming for compatibility with the source, which is
a Substrait (i.e. protobuf) index which is signed. But I agree it looks nicer
with `uint32_t` since that matches the destination (and it seems I was
inconsistent with casting). I have updated it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
