tustvold commented on code in PR #3051:
URL: https://github.com/apache/arrow-datafusion/pull/3051#discussion_r939933304
##########
datafusion/core/src/physical_plan/file_format/parquet.rs:
##########
@@ -342,7 +364,28 @@ impl FileOpener for ParquetOpener {
});
Ok(adapted.boxed())
- })
+ }))
+ }
+}
+
+pub trait ParquetFileReaderFactory:
+ std::fmt::Display + Debug + Send + Sync + 'static
+{
+ fn create_reader(
+ &self,
+ file_meta: FileMeta,
+ metadata_size_hint: Option<usize>,
+ metrics: ParquetFileMetrics,
Review Comment:
I think we could just remove this from here.
Edit: or possibly pass in a reference to the ExecutionPlanMetricsSet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
