Kamil-Konior-Codewise commented on code in PR #3051:
URL: https://github.com/apache/arrow-datafusion/pull/3051#discussion_r940036759
##########
datafusion/core/src/physical_plan/file_format/file_stream.rs:
##########
@@ -50,9 +53,8 @@ pub trait FileOpener: Unpin {
fn open(
&self,
store: Arc<dyn ObjectStore>,
- file: ObjectMeta,
- range: Option<FileRange>,
- ) -> FileOpenFuture;
+ file_meta: FileMeta,
Review Comment:
because FileStream did **move** `ObjectMeta` into `FileOpener`, where
`partition_values` field of `PartitionedFile` is kept as part of
`FileStreamState`. Alternatively we could pass `PartitionedFile` reference to
`FileOpener` or move `PartitionedFile` into `FileOpener` and then return
`partition_values` from `FileOpener`. So I have splitted part related to object
into separate entity named FileMeta. How would you like to approach that ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
