Kamil-Konior-Codewise commented on code in PR #3051:
URL: https://github.com/apache/arrow-datafusion/pull/3051#discussion_r940079979
##########
datafusion/core/src/physical_plan/file_format/parquet.rs:
##########
@@ -100,6 +104,7 @@ impl ParquetExec {
base_config: FileScanConfig,
predicate: Option<Expr>,
metadata_size_hint: Option<usize>,
+ parquet_file_reader_factory: Option<Arc<dyn ParquetFileReaderFactory>>,
Review Comment:
we could take a different route and create builder like method that allows
to override that, what do you think ?
`with_ parquet_file_reader_factory(mut self, ...) -> Self`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
